search

aws / aws-nitro-enclaves-nsm-api

This provides a library for interacting with the Nitro Secure Module, which provides Nitro Enclaves with attestation capability.
Apache License 2.0
62 stars 43 forks source link

Update minimum supported Rust version to v1.58.1. #34

Closed meerd closed 2 years ago

meerd commented 2 years ago

The dependencies require version update for the MSRV.

Signed-off-by: Erdem Meydanli meydanli@amazon.com

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

petreeftime commented 2 years ago

Please list rust version in Cargo.toml: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field and add a badge to the project. Also use Rust 1.56.1 instead, since there was a security fix.

petreeftime commented 2 years ago

Also, please rebase the #35 fix on this, so the tests actually pass.

meerd commented 2 years ago

Please list rust version in Cargo.toml: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field and add a badge to the project. Also use Rust 1.56.1 instead, since there was a security fix.

The MSRV has been updated to 1.58.1 to align with aws-sdk-rust's MSRV. I will go about the badge as part of another PR, because I am planning to use some GitHub workflow magic regarding the rust-version. @petreeftime