aws / aws-nitro-enclaves-nsm-api

This provides a library for interacting with the Nitro Secure Module, which provides Nitro Enclaves with attestation capability.
Apache License 2.0
62 stars 43 forks source link

Feature Request: nix dependency should be optional #40

Closed lfarrel6 closed 1 year ago

lfarrel6 commented 1 year ago

Outline of Issue

I'm implementing a crate which will allow clients to verify attestation documents served from Nitro Enclaves. While most of this is provided by aws-nitro-enclaves-cose, it's useful to use the AttestationDoc struct from the aws_nitro_enclaves_nsm_api crate to access the internals of the attestation document from the Cose payload.

This is currently possible, however the dependency on nix blocks these types being used on non *nix systems.

Proposal

As the nix dependency is only required for the driver module, I think it would be reasonable to introduce a nix feature flag. Leaving the feature default enabled would be no change for the crate as it exists.

lfarrel6 commented 1 year ago

Merged in #41