search

aws / aws-ofi-nccl

This is a plugin which lets EC2 developers use libfabric as network provider while running NCCL applications.
Apache License 2.0
129 stars 51 forks source link

test: Have GitHub workflows build functional tests #419

Closed rajachan closed 3 days ago

rajachan commented 1 month ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rajachan commented 1 month ago

Failing CI actions are an artifact of how the distcheck build is setup, and it needs an update. Will fix that up.

aws-nslick commented 1 month ago

Failing CI actions are an artifact of how the distcheck build is setup, and it needs an update. Will fix that up.

Please check the refactor of this I have in https://github.com/aws/aws-ofi-nccl/pull/420 and consider whether you can rebase atop it.

rajachan commented 1 month ago

Fixed CI and commit message.

Please check the refactor of this I have in https://github.com/aws/aws-ofi-nccl/pull/420 and consider whether you can rebase atop it.

Just noticed this, yeah I can rebase given your PR gets at more of the workflow changes.

AvivBenchorin commented 1 month ago

bot:aws:retest

a-szegel commented 1 month ago

Please merge master.