search

aws / aws-ofi-nccl

This is a plugin which lets EC2 developers use libfabric as network provider while running NCCL applications.
Apache License 2.0
129 stars 51 forks source link

Remove unused reference to OFI_NCCL_ARCHIVE in configure.ac #451

Closed ryanhankins closed 2 weeks ago

ryanhankins commented 2 weeks ago

The use of OFI_NCCL_ARCHIVE was removed in commit: f1a015c916060efc3849331e93a33f6bce80d1cb (Build plugins as DSOs instead of shared libraries)

Remove the reference to it from configure.ac.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ryanhankins commented 2 weeks ago

Maybe I'm misunderstanding, but the removed $2 refers to the second argument in the call to CHECK_PKG_CUDA, which doesn't exist anymore.

AS_IF([test "${check_pkg_found}" = "yes"], [check_pkg_define=1 $1], [check_pkg_define=0 CPPFLAGS="${check_pkg_CPPFLAGS_save}" $2])

bwbarrett commented 2 weeks ago

In M4, the argument not being specified just means that it will evaluate to an undefined string. If you look at most of the AC macros (like AC_CHECK_HEADER), they have a number of optional argumenst that behave this way. There is one gotcha, in that the stanza:

if test "a" = "b" ; then
$1
fi

Can be problematic, because an empty if body in sh is an error. That's why we use AS_IF, which properly handles that case.