search

aws / aws-ofi-nccl

This is a plugin which lets EC2 developers use libfabric as network provider while running NCCL applications.
Apache License 2.0
147 stars 56 forks source link

tuner: Enable tuner init msg on INFO logs #549

Closed arunkarthik-akkart closed 2 months ago

arunkarthik-akkart commented 2 months ago

Description of changes: Enable tuner initialization message to be displayed on all NCCL_DEBUG=INFO and display the logs as part of the default subsystem (INIT)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sunkuamzn commented 2 months ago

bot:aws:retest

a-szegel commented 2 months ago

bot:aws:retest

a-szegel commented 2 months ago

bot:aws:retest

sielicki commented 2 months ago

Can you please remove the merge commit? If you didn't intend for that to happen, consider adopting the following git settings:

git config --global pull.ff only
git config --global pull.rebase true

LGTM otherwise.

arunkarthik-akkart commented 2 months ago

Patch looks fine, but please properly rebase and force push. PRs should not have merge commits in them.

Thanks for the feedback, I have rebased the PR after removing the merge commit.

arunkarthik-akkart commented 2 months ago

Can you please remove the merge commit? If you didn't intend for that to happen, consider adopting the following git settings:

git config --global pull.ff only
git config --global pull.rebase true

LGTM otherwise.

Thanks. I have rebased the PR after removing the merge commit.

a-szegel commented 2 months ago

bot:aws:retest