search

aws / aws-ofi-nccl

This is a plugin which lets EC2 developers use libfabric as network provider while running NCCL applications.
Apache License 2.0
147 stars 56 forks source link

fix(tree): use correct __cplusplus guards #554

Closed aws-nslick closed 2 months ago

aws-nslick commented 2 months ago

Stacked PRs:

fix(tree): use correct __cplusplus guards

the canonical token is __cplusplus not _cplusplus. When this is incorrect, linkage fails as cxx will perform name mangling when including these headers, resulting in a function with that mangle not existing. Signed-off-by: Nicholas Sielicki nslick@amazon.com

aws-nslick commented 2 months ago

aws:bot:retest

aws-nslick commented 2 months ago

aws:bot:retest

a-szegel commented 2 months ago

bot:aws:retest

a-szegel commented 2 months ago

bot:aws:retest