search

aws / aws-ofi-nccl

This is a plugin which lets EC2 developers use libfabric as network provider while running NCCL applications.
Apache License 2.0
147 stars 56 forks source link

nit: deque: avoid typedef hell #561

Closed aws-nslick closed 2 months ago

aws-nslick commented 2 months ago

Stacked PRs:

nit: deque: avoid typedef hell

Prefer to define the structures in vanilla C without relying on any custom typedefs, and move the typedef to the bottom of the file for consumers to use, if they want. Signed-off-by: Nicholas Sielicki nslick@amazon.com

aws-nslick commented 2 months ago

Abandoning this as the build works without it, and it is contentious.