aws / aws-ofi-nccl

This is a plugin which lets EC2 developers use libfabric as network provider while running NCCL applications.
Apache License 2.0
140 stars 54 forks source link

chore(build): replace `-Wc++-compat' with `-x c++' #578

Closed aws-nslick closed 5 days ago

aws-nslick commented 3 weeks ago

Stacked PRs:


chore(build): replace -Wc++-compat' with-x c++'

As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code.

Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward.

Signed-off-by: Nicholas Sielicki nslick@amazon.com