Closed aws-nslick closed 1 month ago
On the top PR, this was amended to use the following macro instead:
#if __has_attribute(__fallthrough__)
# define fallthrough __attribute__((__fallthrough__))
#else
# define fallthrough do {} while (0) /* fallthrough */
#endif
Only GCC accepts the comments, clang requires the attribute. GCC also has the attribute. Prefer the attribute if possible, otherwise, use the comment.
Stacked PRs:
568
567
566
591
588
595
594
593
589
587
577
576
586
574
575
571
570
573
569
565
563
fix(tree): add fallthrough switch markers
Signed-off-by: Nicholas Sielicki nslick@amazon.com