aws / aws-parallelcluster-ui

Apache License 2.0
31 stars 20 forks source link

Fetch PC version during initial load #163

Closed mendaomn closed 1 year ago

mendaomn commented 1 year ago

Description

This PR moves the request for the PC version into the initial load happening before booting the app. This is due to the fact that the rest of the app behaves as if the version is always present, and could crash if the version is not there for some reason.

This also fixes a crash happening whenever the get_version call takes too much time to respond, causing the code accessing the version to crash unexpectedly. In order to reproduce, simply add a timeout in the GetVersion command

Changes

How Has This Been Tested?

PR Quality Checklist

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.