search

aws / aws-parallelcluster-ui

Apache License 2.0
31 stars 18 forks source link

Add support for private PCUI deployment #284

Closed gmarciani closed 8 months ago

gmarciani commented 8 months ago

Changes

  1. De-reverted commits in https://github.com/aws/aws-parallelcluster-ui/pull/251. We reverted them blindly because it appeared to not be working.
  2. Specified architecture x86_64 in base lambda image to avoid lambda failure Runtime.InvalidEntrypoint when the image is build on non x86_64 architectures (eg Macbook M1), see Re:Post article.

*Important Note Every change in this PR come from the original PR https://github.com/aws/aws-parallelcluster-ui/pull/251, with the only exception for Dockerfile.awslambda.

How Has This Been Tested?

  1. Deployed with default public access and verified it works as expected (pages navigation + cluster creation)
  2. Deployed with private access and verified that:
    1. PCUI not accessible from outside the VPC (from my laptop)
    2. PCUI accessible from within the VPC (from an instance running within the VPC)
    3. when accessible it works as expected (pages navigation + cluster creation)

Important: there is a failure in the frontend unit tests that is not related to this change. The failure happens evene without this change and it's pending investigation. The PR can be approved even with this failure.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.