Closed judysng closed 4 months ago
Observations on testing this type of change
The change looks good to me, but the test with 1 cluster does not fully exercise this change as pagination is not used in that case.
To exercise the change there are the following ways:
Solution 3 is what I would recommend to validate this change. Regarding unit tests, let's have a look at the existing unit tests and check if we can cover this change with reasonable time. If you think that lot of effort would be required to add this test, let's proceed with this change and address this test gap in a follow up activity.
Thanks for adding the unit tests even if there was not boilerplate to take advantage from :-)
Changes
How Has This Been Tested?
Deployed in personal account, created and deleted clusters Wrote and ran unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.