search

aws / aws-pdk

The AWS PDK provides building blocks for common patterns together with development tools to manage and build your projects.
https://aws.github.io/aws-pdk/
Apache License 2.0
384 stars 75 forks source link

[FEATURE] (type-safe-api) WebSocket API support for Python #741

Open cogwirrel opened 7 months ago

cogwirrel commented 7 months ago

Describe the feature

Add support for WebSocket APIs in Python

Use Case

Consistency with remainder of PDK

Proposed Solution

Need to add the following:

Other Information

The majority of scaffolding is there already for runtime/handlers/infra - the mustache templates for the python-async-xxx projects in packages/type-safe-api/scripts/generators are copy/pasted REST API implementations that need to be modified to work for websockets.

The projen projects (eg generated-python-async-runtime-project.ts) will likely need to be tweaked slightly to add any dependencies required.

The client library will need to be added - follow the same pattern as the TypeScript websocket client library.

Make sure to remove the validation check once implemented: https://github.com/aws/aws-pdk/blob/a0dda50691a756798521dd1c8cbf0d5c21bdc9d2/packages/type-safe-api/src/project/type-safe-websocket-api-project.ts#L226

Acknowledgements

PDK version used

0.23.26

What languages will this feature affect?

Python

Environment details (OS name and version, etc.)

OSX

github-actions[bot] commented 5 months ago

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

github-actions[bot] commented 5 months ago

Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

github-actions[bot] commented 1 month ago

Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label.