Closed jstrunk closed 1 month ago
While implementing this possible solution, I realized that commitGenerated
is for Projen project files and defaults to true. I'm implementing a new option commitGeneratedCode
with the desired behavior. It will default to false except for python projects that use poetry.
Describe the bug
After cloning a project repo and installing the monorepo's dependencies with
pnpm install
or similar, packages that depend on an API's python runtime package fail because the generated README.md is missing andpoetry install
requires it. UsingcommitGenerated
in the type safe api package or the python runtime options still includes the README.md and the module files in the runtime's .gitignore.Expected Behavior
After cloning a project repo, I should be able to install dependencies and build all packages.
Current Behavior
After cloning the repo and running
pnpm i
:Reproduction Steps
.projenrc.ts
Possible Solution
First,
commitGenerated: true
in a Python runtime package doesn't work..gitignore
still includes the README.md and module directory:packages/api/generated/runtime/python/.gitignore
Second, commitGenerated on the type safe api project should be recursively applied to child projects.
Additional Information/Context
Mitigation:
After defining the api project in .projenrc.ts, add the following:
PDK version used
0.23.40
What languages are you seeing this issue on?
Typescript, Python
Environment details (OS name and version, etc.)
MacOS 14.5 intel