aws / aws-proton-public-roadmap

This is the public roadmap for AWS Proton
https://aws.amazon.com/proton
Other
199 stars 13 forks source link

[Request]: Service Creation Fails if truncated Service Name would be a duplicate #54

Open ilenhartaws opened 3 years ago

ilenhartaws commented 3 years ago

Community Note

Tell us about your request After creating an environment, you can then add multiple services to that environment. For each service set up, it requires a service name, and potentially those names can be quite similar. A truncation occurs during the Cloudformation stack setup that limits various resource names to somewhere around 30 characters, and if the two service names are the same up to that point and happen to use the same service template, deployment of the Proton Service fails and the stack is rolled back.

Example: Deploy two services based on the same service template, to the same environment, in order, and name them: containerservice-prod-service-1 containerservice-prod-service-2 The first will succeed, the second will not. Cloudformation fails, rolls back, and the Proton service is not deployed.

Changing the names to: containerservice-prod-service-1 containerservice-prod-serv-2 Results in both succeeding

It's understood that this is really a Cloudformation/stack behavior, so the "deploying to same environment" piece is probably immaterial. The request here would be an addition to the Proton UI of either:

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

Setting up multiple services, happened to give them quite similar and longer names. It's not difficult to just change the names to be appropriate, but it wasn't immediately obvious why the second service wasn't deploying. Cloudformation error was that a resource already existed, which implied that it was reusing a name, which led to experimentally changing the service name, which fixed the error. Proton itself gave no good information, other than indicating service deployment failed and Cloudformation rolled back.

Are you currently working around this issue? Renaming services so they don't have conflicting names later in Cloudformation.

Additional context Anything else we should know?

Attachments If you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)

rafavallina commented 2 years ago

Hi @ilenhartaws I'm not sure why I didn't see this one before.

Yes, you are right on this. The truncation we have truncates at the end and so if you have long names you might end up with a conflict anyway. I think your two proposed solutions (showing the hard limit in the Proton UI or checking against other existing services) make a lot of sense, but at this point I'm not going to commit to a specific solution, and instead add this to the roadmap, discuss it with the team and see what is the right approach. This feels like something that we can solve relatively quick with a smart simplification, so I don't expect to sit on it for too long.

Thanks for the request!