aws / aws-proton-public-roadmap

This is the public roadmap for AWS Proton
https://aws.amazon.com/proton
Other
199 stars 13 forks source link

[BUG] Old array type input parameteres are not retained after a service instance update #78

Closed davidebonavita closed 6 months ago

davidebonavita commented 8 months ago

e.g.

schema:
  format:
    openapi: "3.0.0"
  service_input_type: "ScheduledLambdaServiceInput"
  pipeline_input_type: "PipelineInputs"
  types:
    ScheduledLambdaServiceInput:
      type: object
      description: "Input properties for a Scheduled Lambda service."
      properties:
         lambda_environment_variables:
          type: array
          description: "List of environment variables for the Lambda function"
          items:
            type: object
            properties:
              key:
                type: string
              value:
                type: string

image

You can see in the deployment history the parameter values in the target spec file

image

In the deployment history you will notice right away that the previous value is not retained, only the ones added during the latest update are retained. If you don't make any change for that input parameter and you edit some other field, all the old values are removed and an empty value for lambda_environment_variables will be used ("[]").

image

nouvionp commented 8 months ago

Thanks David for reporting this issue, the team will be looking into it this week.

davidebonavita commented 7 months ago

Hello @nouvionp thank you for this! I'm wondering if you're able confirm it's a bug?

Thank you again

nouvionp commented 7 months ago

Yes it's a bug, we have fix for it now, that we will deploy probably by end of next week.

davidebonavita commented 7 months ago

Hi @nouvionp sorry I don't know if there's a way to check if a fix has been deployed?

nouvionp commented 7 months ago

Sorry there is no way for you to check when something is fully deployed. I will mark this issue as resolved when it's done.

We had some issues last week so started the deployment this AM and the fix is deployed to NRT but no other regions. PDX and SIN tomorrow, IAD and other regions should be the next day. Current schedule is that the deployment will be complete by EOD Thursday.

davidebonavita commented 6 months ago

Hi @nouvionp it seems the issue has been fixed now?

nouvionp commented 6 months ago

Yes that's correct, the fix was fully deployed, I will close this issue but please let me know or feel free to re-open this issue if you are still seeing the old behavior. Thanks!