Open mainframenzo opened 1 year ago
Hi @mainframenzo,
Thank you for your feedback, we are aware of this problem and the root cause of the problem is 2) in the issue description. A fix was merged in #1008 and the problem should no longer exist in the mainline
branch. Once the fix has been released, the example will work again in the release
branch.
We will keep this issue open until we have confirmed that the example is working again in the release
branch.
EDIT: After re-evaluating the issue, I believe you are reporting a different problem. We will investigate further and reply here with further information.
After experimentation, I discovered that no. 1 in your bug report may be caused by missing instructions. Step 5 of the README instructs building the repository yarn monorepo workspace, which links the stage-deadline
command to become available from yarn in the example. We should reorder the instructions to instead build the workspace in the first step.
For the issue with running the example in the release
branch (2 in your bug report), please see #1008 which has been merged and is pending release.
Hi folks,
The example Typescript tutorial linked here is broken for mainline branch and release branch. I expected the mainline branch to be broken based on the docs from the linked tutorial, but not the release branch.
What's wrong: 1)
yarn stage
step is broken, and it errors on both mainline and release branches withCannot find module './stage-deadline.js'
1)./build.sh
step is broken, and it errors on both mainline and release branches with...LICENSE should contain exactly
. Not sure if this is because I had to skipyarn stage
.Reproduction Steps
I found it helpful to use Docker to reproduce this. (aside: perhaps ya'll can build on this example to provide a deployment environment that works out of the box?)
Docker build command:
DOCKER_BUILDKIT=1 docker build -f ./dockerfile --build-arg EXTEND="public.ecr.aws/docker/library/ubuntu:focal-20230308" -t "rfdk-deploy:latest"
Docker file (lower-cased)
dockerfile
:This is :bug: Bug Report