aws / aws-rfdk

The Render Farm Deployment Kit on AWS is a library for use with the AWS Cloud Development Kit that helps you define your render farm cloud infrastructure as code.
https://docs.aws.amazon.com/rfdk/index.html
Apache License 2.0
105 stars 38 forks source link

test: add unique discriminator to testing-tier props #1166

Closed marofke closed 6 months ago

marofke commented 6 months ago

Problem

Integration tests were failing to deploy the Bastion instance in the testing tier, since the name is not unique. Changes in https://github.com/aws/aws-rfdk/pull/1165 enabled a feature flag that append a unique hash to the construct name, but base the hash on the CFN node a step down from the full stack name, resulting in the same hash for every test stack.

Solution

Append a 'discriminator' tag to the Bastion name, which helps keep the name unique between instances of the testing-tier. I also appended the "integStackTag" so multiple deployments won't cause resource conflicts.

Testing

Built locally, confirming no linting errors.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license