search

aws / aws-rfdk

The Render Farm Deployment Kit on AWS is a library for use with the AWS Cloud Development Kit that helps you define your render farm cloud infrastructure as code.
https://docs.aws.amazon.com/rfdk/index.html
Apache License 2.0
110 stars 42 forks source link

Further Expose Secrets Manager Auto Registration Settings #1205

Open pwortas opened 8 months ago

pwortas commented 8 months ago

Currently, configure_secrets_management_auto_registration() only accepts a SubnetSelection when determining which networks to add to the identity auto registration.

In a hybrid environment, we have workers coming up in subnets not managed by RFDK or not in AWS at all. It would be nice to be able to provide a list of additional CIDR so that we can keep our repo configuration fully in code and not require post-deployment clickops.

Use Case

  1. Deploy an RFDK farm from code.
  2. Add on-prem workers.
  3. Worker subnets require manual configuration of the identity management backend.

Proposed Solution

Add the ability to cumulatively append subnets to the configuration prior to deployment that does not rely on ISubnet or SubnetSelections. A new prop could be possibly constructed that takes a status, a role and the cidr as a string.

This is a :rocket: Feature Request

jusiskin commented 8 months ago

Thanks for submitting this feature request @pwortas. This seems like a useful enhancement for RFDK users. We have added this to our backlog and report here when we have updates.