fix: Add feature flag to unblock new deployments - Githubissues

aws / aws-rfdk

The Render Farm Deployment Kit on AWS is a library for use with the AWS Cloud Development Kit that helps you define your render farm cloud infrastructure as code.

https://docs.aws.amazon.com/rfdk/index.html

Apache License 2.0

111 stars 42 forks source link

fix: Add feature flag to unblock new deployments #1365

Closed marofke closed 3 weeks ago

marofke commented 3 weeks ago

Problem

Deployments of RFDK to brand new accounts would fail with:

The Launch Configuration creation operation is not available in your account. Use launch templates to create configuration templates for your Auto Scaling groups.

This is because Launch Configurations were deprecated, and recently denied for new accounts in https://github.com/aws/aws-cdk/pull/25910

Solution

Added the feature flag that converts launch configurations to launch templates, as described in the documentation: https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md#aws-cdkaws-autoscalinggeneratelaunchtemplateinsteadoflaunchconfig

Testing

tried deploying the All-In-AWS-Infrastructure-Basic example to a new AWS account, and confirmed I hit this error
with these changes, was able to deployments did not hit the launch configuration error

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license