search

aws / aws-sam-cli

CLI tool to build, test, debug, and deploy Serverless applications using AWS SAM
https://aws.amazon.com/serverless/sam/
Apache License 2.0
6.53k stars 1.17k forks source link

Feature request: Support dotnet lambda container builds #4453

Open 1davidmichael opened 1 year ago

1davidmichael commented 1 year ago

Describe your idea/feature/enhancement

All other language run-times support the --use-container option for sam build except dotnet runtimes. With the addition of build images for dotnet it should now be possible to do this.

I've tested this with a quick hack here and it appears to work. I was able to successfully build and publish a dotnet6 runtime lambda via the following commands:

sam build -u
sam deploy --config-file samconfig.toml

However, I am guessing the change from read-only to read-write for the manifest dir is not ideal.

Proposal

Add support for dotnet lambda builds via docker containers to align with other runtime supported builds.

Things to consider:

  1. May require updates to the docker build logic to support how it is handled via dotnet
torresxb1 commented 1 year ago

Thanks for the feature request! Write permissions would indeed require some caution here. Let me bring this up to the team for discussion.

torresxb1 commented 1 year ago

Hi @1davidmichael, wanted to give an update after discussing with the team: this is something that was on our map already, and we're in the process of prioritizing it, but we can't give any timelines at the moment.

1davidmichael commented 1 year ago

@torresxb1 awesome to here. Thanks!