aws / aws-sdk-cpp

AWS SDK for C++
Apache License 2.0
1.98k stars 1.06k forks source link

SimpleStreamBuf data access #2698

Closed JBKacerovsky closed 1 year ago

JBKacerovsky commented 1 year ago

Issue #, if available:

Description of changes:

Added getters for private members m_buffer and m_bufferSize to SimpleStreamBuf. In my project I needed to pass objects downloaded from s3 to another function as char * this minor change made accessing the data a bit more convenient than using SimpleStreamBuf::str()

In benchmarks it is also marginally faster, but the difference is negligible.

Check all that applies:

Check which platforms you have built SDK on to verify the correctness of this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions[bot] commented 1 year ago

Greetings! It looks like this PR hasn’t been active in longer than a week, add a comment or an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one.