Added getters for private members m_buffer and m_bufferSize to SimpleStreamBuf. In my project I needed to pass objects downloaded from s3 to another function as char * this minor change made accessing the data a bit more convenient than using SimpleStreamBuf::str()
In benchmarks it is also marginally faster, but the difference is negligible.
Check all that applies:
[X] Did a review by yourself.
[ ] Added proper tests to cover this PR. (If tests are not applicable, explain.) Very minor change. Only exposes access to existing member variables without functional changes.
[ ] Checked if this PR is a breaking (APIs have been changed) change.
[ ] Checked if this PR will not introduce cross-platform inconsistent behavior.
[ ] Checked if this PR would require a ReadMe/Wiki update.
Check which platforms you have built SDK on to verify the correctness of this PR.
[X] Linux
[ ] Windows
[ ] Android
[ ] MacOS
[ ] IOS
[ ] Other Platforms
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Greetings! It looks like this PR hasn’t been active in longer than a week, add a comment or an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one.
Issue #, if available:
Description of changes:
Added getters for private members m_buffer and m_bufferSize to SimpleStreamBuf. In my project I needed to pass objects downloaded from s3 to another function as
char *
this minor change made accessing the data a bit more convenient than using SimpleStreamBuf::str()In benchmarks it is also marginally faster, but the difference is negligible.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.