aws / aws-sdk-cpp

AWS SDK for C++
Apache License 2.0
1.98k stars 1.06k forks source link

Add SDKOption for default Credentials Provider Chain #2815

Closed MitchellKagerKodiak closed 3 months ago

MitchellKagerKodiak commented 10 months ago

Issue #, if available: related to 150; this is kind of a workaround whereby developer can set their default chain to include STSProfileCredentialsProvider. Just opened an issue / feature request 2814.

Description of changes: If provided in SDKOption, initialization will resolve closure and set that value in static variable. If not provided, configure static variable with DefaultAWSCredentialsProviderChain. Most usages of DefaultAWSCredentialsProviderChain throughout clients has been replaced with GetDefaultCredentialsProviderChain.

I could use some help writing test cases, and I probably missed a couple places where I need to replace DefaultAWSCredentialsProviderChain.

I know this looks tedious to review; but, all of the logic changes are in src/aws-cpp-sdk-core. Everything outside of that is just changing existing usages of DefaultAWSCredentialsProviderChain => GetDefaultCredentialsProviderChain across the services' clients.

Check all that applies:

Check which platforms you have built SDK on to verify the correctness of this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jmklix commented 3 months ago

Thanks for taking the time and effort to make this PR. But we don't want to accept these changes, as we have plans to rework the Credentials Provider.