callback set in SetDataSentEventHandler is not called on S3Crt PutRequest

thierryba commented 9 months ago

Describe the bug

I am setting a callback when I do an upload so that I can know the progress of the current upload. It works fine with the s3Client but not the s3CrtClient

Expected Behavior

it should get called at least from time to time...

Current Behavior

the callback is never called.

Reproduction Steps

Aws::S3::S3Client client( ... );
Aws::S3Crt::Model::PutObjectRequest request;
   request.SetBucket(bucketName);
    request.SetKey(keyName);

    ...
    request.SetDataSentEventHandler([](const Aws::Http::HttpRequest*, long long) {
        std::cout << "callback" << std::endl;
    });

Aws::S3Crt::Model::PutObjectOutcome outcome = client.PutObject(request);

Possible Solution

No response

Additional Information/Context

No response

AWS CPP SDK version used

1.11.258

Compiler and Version used

Apple clang version 15.0.0 (clang-1500.1.0.2.5)

Operating System and version

macOS Sonoma 14.3

jmklix commented 8 months ago

I can confirm that SetDataSentEventHandler is not working for s3crt. Working on a possible fix

github-actions[bot] commented 8 months ago

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.

aws / aws-sdk-cpp