sbiscigl
commented
1 month ago Hey thanks for reaching out, we took a look into it
Reproduction Steps Build the SDK, statically link it to another binary, build that binary with tsan option, and initialize the SDK
Without a minimal reproducible example theres not a lot we can do as theres too many variables with your enviornment and usage. For instance we do not know hwo you are creating and using the SDK in /builds/splcore/main/src/framework/tests/FrameworkTester.cpp:88:5. I tried replicating your example and could not.
Project Structure:
~/sdk-usage-workspace ❯❯❯ tree -L 1
.
├── CMakeLists.txt
├── Dockerfile
├── main.cpp
└── replicate.shDockerfile
# Using offical Amazon Linux 2023 image from public ECR
FROM public.ecr.aws/amazonlinux/amazonlinux:2023
# Install compiler et al.
RUN yum groupinstall "Development Tools" -y
# Install required dependencies
RUN yum install -y curl-devel openssl-devel ninja-build cmake3 libtsan
# Install sdk
RUN git clone --depth 1 --recurse-submodules https://github.com/aws/aws-sdk-cpp && \
cd aws-sdk-cpp && \
mkdir build && \
cd build && \
cmake -G Ninja -DBUILD_ONLY="core" \
-DCMAKE_CXX_FLAGS="-fsanitize=thread" \
-DBUILD_SHARED_LIBS=OFF \
-DENABLE_ZLIB_REQUEST_COMPRESSION=OFF \
-DAUTORUN_UNIT_TESTS=OFF .. && \
cmake --build . && \
cmake --install .
# Copy over and build
RUN mkdir sdk-example
COPY CMakeLists.txt /sdk-example/CMakeLists.txt
COPY main.cpp /sdk-example/main.cpp
RUN cd sdk-example &&\
mkdir build &&\
cd build &&\
cmake -G Ninja -DBUILD_SHARED_LIBS=OFF \
-DCMAKE_CXX_FLAGS="-fsanitize=thread" .. && \
cmake --build .CMakeLists.txt
cmake_minimum_required(VERSION 3.13)
project(sdk_usage_workspace)
set(CMAKE_CXX_STANDARD 20)
find_package(AWSSDK REQUIRED COMPONENTS core)
add_executable(${PROJECT_NAME} "main.cpp")
target_link_libraries(${PROJECT_NAME} PRIVATE ${AWSSDK_LINK_LIBRARIES})main.cpp
#include <aws/core/Aws.h>
using namespace Aws;
auto main() -> int
{
SDKOptions options;
Aws::InitAPI(options);
Aws::ShutdownAPI(options);
}replicate.sh
#!/bin/zsh
set -u
# build image
docker build -t test-image .
# run example
docker run \
-e AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} \
-e AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} \
-e AWS_SESSION_TOKEN=${AWS_SESSION_TOKEN} \
--name test-image test-image /sdk-example/build/sdk_usage_workspacewhen we run with ./replicated.sh we see the sample application exit successfully
~/sdk-usage-workspace ❯❯❯ docker ps -a
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
c799a4a427de test-image "/sdk-example/build/…" About a minute ago Exited (0) 59 seconds ago test-imageSo it looks to be working as intended in a standalone environment. If you can update this example to replicate your issue we'd be happy to take a look at it.
A possible issue with your code, not sure if youre doing this, is you should not be wrapping the SDK init-shutdown in any static objects. from our basic usage page
The SDK for C++ and its dependencies use C++ static objects, and the order of static object destruction is not determined by the C++ standard. To avoid memory issues caused by the nondeterministic order of static variable destruction, do not wrap the calls to Aws::InitAPI and Aws::ShutdownAPI into another static object.
github-actions[bot]
Describe the bug
Our sanitizers are picking up a leaked thread when simply initializing the SDK / API,
Expected Behavior
No leak will occur
Current Behavior
A thread leak in TSAN is occurring
Reproduction Steps
Build the SDK, statically link it to another binary, build that binary with tsan option, and initialize the SDK
Possible Solution
No response
Additional Information/Context
No response
AWS CPP SDK version used
1.11.266
Compiler and Version used
clang 13
Operating System and version
Linux x86_64