RanVaknin
commented
2 years ago Hi @ParthaI ,
Thanks for opening this thread and engaging in the community!
After looking into this in depth I came up with these 2 conclusions:
-
the backup service API does not offer a flattering response when making a request to a backup vault with 0 events in it. Ideally it should return an empty array.
-
The V1 SDK simply returns an empty
&backup.GetBackupVaultNotificationsOutput{}object and ignores the exception given from the server. This is why you are seeing a more flattering response in V1, but the truth is that the SDK should in fact raise an exception. If you enable wire logs on V1 you'll see the following response:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 400 Bad Request
Content-Length: 137
Content-Type: application/json
Date: Fri, 14 Oct 2022 15:20:45 GMT
X-Amzn-Errortype: ResourceNotFoundException:http://internal.amazon.com/coral/com.amazonaws.services.cryo/
X-Amzn-Requestid: <redacted>
-----------------------------------------------------
2022/10/14 08:20:45 {"Code":"ERROR_2106","Context":"testVault","Message":"Failed reading notifications from database for Backup vault testVault","Type":null}
{
}I have reached out to the backup service team with a feature request to try and return a more sensible response in the form of an empty array. Since the V2 SDK is behaving as expected so there is no action item for us here.
If you have any additional questions please let me know. Thanks again! Ran~
github-actions[bot]
ParthaI
Describe the bug
While making the
GetBackupVaultNotificationsAPI call with AWS SDK V1, instead of throwing an error it returns a null value if no event notification is available but the AWS SDK V2 throwing an error (Error: operation error Backup: GetBackupVaultNotifications, https response error StatusCode: 400, RequestID: ffb8c91d-b86c-426b-ad2b-3c495a4e3da0, api error ERROR_2106: Failed reading notifications from database for Backup vault aws/efs/automatic-backup-vault) instead of returning null value.Expected Behavior
The API should not return an error if there is no event notification available for a backup vault.
Current Behavior
The API always throws an error if no data is available.
Reproduction Steps
Possible Solution
No response
Additional Information/Context
No response
AWS Go SDK V2 Module Versions Used
Compiler and Version used
go version go1.19.2 darwin/arm64
Operating System and version
MacOS Big Sur - Version 11.4