lucix-aws
commented
3 months ago @mappie-grofers --
Based on the Java issue you've provided, the way this is done in the Java SDK is actually through generic HTTP request manipulation. This same level of customization is possible in the Go V2 SDK as well through middleware.
The following example demonstrates how to do this:
package main
import (
"context"
"fmt"
"log"
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/config"
"github.com/aws/aws-sdk-go-v2/service/s3"
"github.com/aws/smithy-go/middleware"
smithyhttp "github.com/aws/smithy-go/transport/http"
)
type withQueryParam struct {
key, value string
}
var _ middleware.SerializeMiddleware = (*withQueryParam)(nil)
func (*withQueryParam) ID() string { return "withQueryParam" }
func (m *withQueryParam) HandleSerialize(
ctx context.Context, in middleware.SerializeInput, next middleware.SerializeHandler,
) (
out middleware.SerializeOutput, md middleware.Metadata, err error,
) {
req, ok := in.Request.(*smithyhttp.Request)
if !ok {
return out, md, fmt.Errorf("unexpected transport %T", in.Request)
}
// smithyhttp.Request embeds http.Request
req.URL.RawQuery = fmt.Sprintf("%s&%s=%s", req.URL.RawQuery, m.key, m.value)
return next.HandleSerialize(ctx, in)
}
// you don't _need_ to have this but it makes adding the middleware to multiple
// operations much easier
func addWithQueryParam(key, value string) func(*s3.Options) {
return func(o *s3.Options) {
o.APIOptions = append(o.APIOptions, func(s *middleware.Stack) error {
return s.Serialize.Add(&withQueryParam{key, value}, middleware.After)
})
}
}
func main() {
cfg, err := config.LoadDefaultConfig(context.Background())
if err != nil {
log.Fatal(err)
}
svc := s3.NewFromConfig(cfg, func(o *s3.Options) {
o.ClientLogMode = aws.LogRequest
})
svc.GetObject(context.Background(), &s3.GetObjectInput{
Bucket: aws.String("bucket"),
Key: aws.String("key"),
}, addWithQueryParam("foo", "bar"))
}This is just with GetObject as an example, you can apply this to any S3 operation using functional options like I've done here.
Please try that and let us know if it works for you.
github-actions[bot]
mappie-grofers
Describe the feature
Ideally select object content should be similar to getObject except it does select on conent. Currently it lacks VersionId support in params. There is a way to specify version id in s3 select as per this github issue: https://github.com/aws/aws-sdk-java/issues/2357#issuecomment-644896382
Use Case
We only want to fetch the required content hence using selectObjectContent. But due to this we are not able to select content from older versions. Please add VersionId support in SelectObjectContent
Proposed Solution
Adding support of versionId as it is in GetObject
Other Information
There is a way to specify version id in s3 select as per this github issue: https://github.com/aws/aws-sdk-java/issues/2357#issuecomment-644896382
Acknowledgements
AWS Go SDK V2 Module Versions Used
github.com/aws/aws-sdk-go-v2/service/s3 v1.40.2
Go version used
1.21