search

aws / aws-sdk-go-v2

AWS SDK for the Go programming language.
https://aws.github.io/aws-sdk-go-v2/docs/
Apache License 2.0
2.59k stars 624 forks source link

CompleteMultipartUpload xml has a bad tag name "CompletedMultipartUpload" (need remove the 'd' letter) #927

Closed nabbar closed 3 years ago

nabbar commented 3 years ago

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug The xml sent to complete a multipart upload has a bad tag name. The tag name sent is "CompletedMultipartUpload" (cf line 153 in the file : https://github.com/aws/aws-sdk-go-v2/blob/master/service/s3/serializers.go#L153) image

The AWS API reference documentation report that the tag name must be "CompleteMultipartUpload" (not the 'd' at the end of Complete word). You can find it at this link https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html : image

I think this bug was appear with the v0.26.0 release and later (as the v0.29.0 I use).

Version of AWS SDK for Go: v0.29.0

Version of Go : go1.15.2

nabbar commented 3 years ago

Strangely, when I looking for this bug into the smithy definition model json, I don't find it

https://github.com/aws/aws-sdk-go-v2/blob/v0.29.0/codegen/sdk-codegen/aws-models/s3.2006-03-01.json#L1185 image

Maybe a bug into the codegen ?

Or need defined the xmlname into the traits definition of the structure CompletedMultipartUpload at line 1208 ?https://github.com/aws/aws-sdk-go-v2/blob/v0.29.0/codegen/sdk-codegen/aws-models/s3.2006-03-01.json#L1208

image

thanks in advance for helping :)

skmcgrail commented 3 years ago

Thank you for bringing this to our attention @nabbar and your detailed research into the issue. This appears to be an edge case in our code generation that is not correctly applying the xmlName trait. We will work on getting this fixed in our next release.

jasdel commented 3 years ago

This issue was fixed in https://github.com/aws/aws-sdk-go-v2/pull/965 and will be included in the SDK's tagged release.

github-actions[bot] commented 3 years ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.