aws / aws-sdk-go

AWS SDK for the Go programming language.
http://aws.amazon.com/sdk-for-go/
Apache License 2.0
8.62k stars 2.07k forks source link

spelling issues in *.json files used to auto generate go files #518

Closed client9 closed 8 years ago

client9 commented 8 years ago

Hello! Loving the aws-sdk for golang.

I found these nits. I can generate a pull request, for json and/or go files, but not sure how you want to handle these if at all.

regards,

n

./models/apis/datapipeline/2012-10-29/docs-2.json:14:771:found "accomodate" a misspelling of "accommodate"
./models/apis/datapipeline/2012-10-29/docs-2.json:21:236:found "sucessful." a misspelling of "successful."
./models/apis/datapipeline/2012-10-29/docs-2.json:313:20:found "comparision" a misspelling of "comparison"
./models/apis/elasticbeanstalk/2010-12-01/docs-2.json:820:171:found "milisecond" a misspelling of "millisecond"
./models/apis/es/2015-01-01/docs-2.json:120:27:found "occured" a misspelling of "occurred"
./models/apis/lambda/2015-03-31/docs-2.json:15:166:found "paramter." a misspelling of "parameter."
./models/apis/lambda/2015-03-31/docs-2.json:431:69:found "paramter" a misspelling of "parameter"
./models/apis/lambda/2015-03-31/docs-2.json:432:191:found "paramter" a misspelling of "parameter"
./models/apis/mobileanalytics/2014-06-05/docs-2.json:65:51:found "occured" a misspelling of "occurred"
./models/apis/machinelearning/2014-12-12/docs-2.json:118:96:found "acknowledgement" a misspelling of "acknowledgment"
./models/apis/machinelearning/2014-12-12/docs-2.json:128:98:found "acknowledgement" a misspelling of "acknowledgment"
./models/apis/machinelearning/2014-12-12/docs-2.json:138:103:found "acknowledgement" a misspelling of "acknowledgment"
./models/apis/machinelearning/2014-12-12/docs-2.json:148:97:found "acknowledgement" a misspelling of "acknowledgment"
./models/apis/machinelearning/2014-12-12/docs-2.json:158:91:found "acknowledgement" a misspelling of "acknowledgment"
./models/apis/machinelearning/2014-12-12/docs-2.json:168:88:found "acknowledgement" a misspelling of "acknowledgment"
./models/apis/redshift/2012-12-01/docs-2.json:1440:336:found "withing" a misspelling of "within"
./models/apis/swf/2012-01-25/docs-2.json:957:175:found "futher" a misspelling of "further"
./models/apis/swf/2012-01-25/docs-2.json:958:165:found "futher" a misspelling of "further"
./models/apis/swf/2012-01-25/docs-2.json:959:176:found "futher" a misspelling of "further"
./models/apis/swf/2012-01-25/docs-2.json:960:159:found "futher" a misspelling of "further"
./models/apis/swf/2012-01-25/docs-2.json:961:174:found "futher" a misspelling of "further"
./models/apis/swf/2012-01-25/docs-2.json:962:165:found "futher" a misspelling of "further"
./models/apis/swf/2012-01-25/docs-2.json:963:167:found "futher" a misspelling of "further"
jasdel commented 8 years ago

Thanks for reporting these @client9 Lets hold off on a PR for now. I recently noticed these a few days ago with the Go Report Card http://goreportcard.com/report/aws/aws-sdk-go tool, and roughly looking at it they look to be similar lists. I'll get these forwarded upstream to the service owners.

client9 commented 8 years ago

ha! great! I wrote the tool that goreportcard is using https://github.com/client9/misspell Ok good to know it and goreportcard and getting noticed and being useful.

It's fast and easy to integrate into your build / test / lint process see the readme at client9/misspell . Feedback most welcome and thank you!

cc @shawnps

jasdel commented 8 years ago

Thanks again @client9 i've reported these to the service teams so we can get the models updated. thanks for lettings us know about your utility and the spelling errors!