aws / aws-sdk-java-v2

The official AWS SDK for Java - Version 2
Apache License 2.0
2.17k stars 840 forks source link

DynamoDB Enhanced Client: batch writes #3392

Open chrylis opened 2 years ago

chrylis commented 2 years ago

Describe the feature

Requested feature: batchPutItem(Collection<T>) and batchUpdateItem(Collection<T>) methods on DynamoDbTable.

Use Case

The low-level client supports batch transactional writes, and the Enhanced client works by mapping POJOs onto low-level operations. I would like to write a series of records transactionally from POJOs, but the Enhanced client only supports single-record operations. Instead, I want to prepare the records to be saved and save them as a batch.

Proposed Solution

PutItemOperation (with the other TableOperations) generates a PutItemRequest, and the low-level client already supports the batchWriteItem operation that takes multiple PutItemRequests and batches them. All of the existing logic for the Enhanced client could remain in place with a scatter-gather implementation that collects the generated requests and executes them via batchWriteItem.

Other Information

No response

Acknowledgements

AWS Java SDK version used

2.17.260

JDK version used

OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed mode)

Operating System and version

Gentoo Linux

debora-ito commented 2 years ago

We do have batch operations in DynamoDbEnhancedClient, is this what you're looking for?

https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/enhanced/dynamodb/DynamoDbEnhancedClient.html

They're not DynamoDbTable operations because you can specify writes to different tables in the same request.

chrylis commented 2 years ago

So... it would be this?

enhancedClient.transactWriteItems(twi ->
  twi.addPutItem(table, record1).addPutItem(table, record2)
)

Not the worst API in the SDK, but still requires wrangling multiple resources unnecessarily, and it would be convenient to be able to access the batch/transact operations directly from the DynamoDbTable object.

debora-ito commented 2 years ago

The records need to be provided anyway, so the only "unnecessary resource" you mean is the table?

Did you envision something much different in your feature request if the operations were from the DynamoDbTable directly?

chrylis commented 2 years ago

The unnecessary resource is the DynamoDB client; in my code, I'm generally not exposing that as it's owned by a service object, and the business code uses only table.

nickcaballero commented 2 years ago

Along the same lines, a batchGet on the DynamoDbTable would be nice.

nickcaballero commented 2 years ago

Regarding the batchPut, it can be written as a TableOperation that takes a BatchWriteItemEnhancedRequest<T> and returns a BatchWriteResult<T>, where the request/result are more strictly typed versions of the already available types. That would also pave the road for supporting a batchDelete.

debora-ito commented 1 year ago

Quick update: this was added to the backlog.

Anyone who'd like to see this supported in the Java SDK make sure to add a 👍 to the original description to help us with prioritization.