aws / aws-sdk-java-v2

The official AWS SDK for Java - Version 2
Apache License 2.0
2.16k stars 840 forks source link

Fix a bug that prevents a retry strategy override to get used #5286

Closed sugmanue closed 3 months ago

sugmanue commented 3 months ago

Motivation and Context

Fixes a bug that was found that prevents a retry strategy override from being used as it was overwritten once again to configure it for AWS. This is not needed as the AwsDefaultClientBuilder takes care of this without resorting on the SdkDefaultClientBuilder. Also added tests to verify that this actually works for both sync and async scenarios.

Modifications

NOTE the build will fail since there were changes to the clients codegen. I will update the tests if the approach looks sound.

Testing

Screenshots (if appropriate)

Types of changes

Checklist

License

sonarcloud[bot] commented 3 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
73.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sugmanue commented 3 months ago

Merged in a different PR.