Implement return values for enhanced UpdateItem - Githubissues

aws / aws-sdk-java-v2

The official AWS SDK for Java - Version 2

Apache License 2.0

2.16k stars 840 forks source link

Implement return values for enhanced UpdateItem #5311

Closed shetsa-amzn closed 3 months ago

shetsa-amzn commented 3 months ago

Adds support for specifying ReturnValues in UpdateItemEnhancedRequest. Defaults to the current behavior ALL_NEW.

Motivation and Context

https://github.com/aws/aws-sdk-java-v2/issues/4247

Testing

Adding Units to Cover all the options of ReturnValue including validating the behavior when its not set.

Screenshots (if appropriate)

Types of changes

[] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)

Checklist

[ x] I have read the CONTRIBUTING document
[ x] Local run of mvn install succeeds
[ x] My code follows the code style of this project
[ x] My change requires a change to the Javadoc documentation
[ x] I have updated the Javadoc documentation accordingly
[ x] I have added tests to cover my changes
[ x] All new and existing tests passed
[ ] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
[ ] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

[ x] I confirm that this pull request can be released under the Apache 2 license

davidh44 commented 3 months ago

Can we add end-to-end tests as well? https://github.com/aws/aws-sdk-java-v2/tree/master/services-custom/dynamodb-enhanced/src/it/java/software/ama

shetsa-amzn commented 3 months ago

Can we add end-to-end tests as well? https://github.com/aws/aws-sdk-java-v2/tree/master/services-custom/dynamodb-enhanced/src/it/java/software/ama

Added Integration tests to the second revision.

davidh44 commented 3 months ago

Looks good, approved, can we add a changelog entry? https://github.com/aws/aws-sdk-java-v2/blob/master/CONTRIBUTING.md#pull-request-readiness

shetsa-amzn commented 3 months ago

Looks good, approved, can we add a changelog entry? https://github.com/aws/aws-sdk-java-v2/blob/master/CONTRIBUTING.md#pull-request-readiness

Added. Thanks

sonarcloud[bot] commented 3 months ago

Quality Gate failed

Failed conditions
11.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud