aws / aws-sdk-java-v2

The official AWS SDK for Java - Version 2
Apache License 2.0
2.16k stars 840 forks source link

Throw converter not found instead of generic IndexOutOfBound exception #5538

Open ar0d10n opened 1 month ago

ar0d10n commented 1 month ago

Throw converter not found instead of generic IndexOutOfBound exception

Motivation and Context

3845

Modifications

Added parameter validation and throwing appropriate exception instead of generic IndexOutOfBound for default attribute converter and enhanced document

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

Checklist

License

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
62.9% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

debora-ito commented 1 month ago

@ar0d10n this seems a duplicate of https://github.com/aws/aws-sdk-java-v2/pull/5329, should we close that one?

ar0d10n commented 3 weeks ago

@debora-ito yes, we can close the #5329 in favor of this PR since current one has build results