aws / aws-sdk-java-v2

The official AWS SDK for Java - Version 2
Apache License 2.0
2.16k stars 840 forks source link

Refactor to avoid impacting JSON with RPCv2 logic #5544

Closed sugmanue closed 3 weeks ago

sugmanue commented 1 month ago

Motivation and Context

This change refactors the previously introduced (see #5543) logic to handle RPCv2 unmarshalling to move it into the RPCv2 package and keeping the JSON unmarshalling logic as it was.

In order to accomplish this we changed the way the unmarshaller gets its registry to allow it to be pass down using the protocol factory builder.

This will reduce the potential impact that this new protocol might have on the already existing ones.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

Checklist

License

sonarcloud[bot] commented 4 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
46.7% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint