search

aws / aws-sdk-java-v2

The official AWS SDK for Java - Version 2
Apache License 2.0
2.16k stars 840 forks source link

Add g6e instance type #5553

Closed github-clement-schiano closed 3 weeks ago

github-clement-schiano commented 3 weeks ago

Motivation and Context

This commit is for the launch of the new g6e instance types

debora-ito commented 3 weeks ago

Hi @github-clement-schiano I can't see the diff but I assume you added the g6e instance types to the InstanceType enum in the EC2 service model.

Model changes need to be made upstream in the SDK release process, by the service team who owns the model. I'll reach out to the EC2 team and ask them to add it.

github-clement-schiano commented 3 weeks ago

Hello @debora-ito, that’s exactly what I was aiming for. Thank you for your help!

yaronr commented 1 week ago

Hi @debora-ito We're an AWS customer, and we use AWS Java SDK 2.28.2 to launch servers for our customers. The code below, for relevant regions (us-east-1) will log all instance types except G6E.

I know that there's a process to follow at a large organization like AWS, but right now our clients can't use this instance type. Appreciate if you could re consider accepting the PR, or if you could push the service team to make this change.

DescribeInstanceTypesIterable responseIter = ec2.describeInstanceTypesPaginator(describeInstanceTypesRequest);
      for (InstanceTypeInfo info : responseIter.instanceTypes()) {
...
          log.debug(st.getName());