aws / aws-sdk-java-v2

The official AWS SDK for Java - Version 2
Apache License 2.0
2.2k stars 853 forks source link

Codegen: Fix flipped conditional for the simple method warning log #5558

Closed brandondahler closed 1 month ago

brandondahler commented 2 months ago

Motivation and Context

Noticed during code generation there are warnings about not allowlisting certain operations as simple methods, but the warning doesn't actually apply because the methods do have required arguments.

Modifications

Testing

Screenshots (if appropriate)

Logged output

A potential simple method exists that isn't explicitly excluded or included: getThread

Applicable model snippet:

        "GetThreadInput": {
            "type": "structure",
            "required": [
                "threadId"
            ],

Types of changes

Checklist

License

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud