Handled surface area review comments - Githubissues

aws / aws-sdk-java-v2

The official AWS SDK for Java - Version 2

Apache License 2.0

2.16k stars 840 forks source link

Handled surface area review comments #5563

Closed joviegas closed 3 weeks ago

joviegas commented 3 weeks ago

Motivation and Context

Surface area review comments to remove some configs from public apis.
Rename API names for config

Modifications

Update defaults
Rename API name to make it user friendly

Testing

Updated existing test cases
Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist

[ ] I have read the CONTRIBUTING document
[ ] Local run of mvn install succeeds
[ ] My code follows the code style of this project
[ ] My change requires a change to the Javadoc documentation
[ ] I have updated the Javadoc documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed
[ ] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
[ ] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

[ ] I confirm that this pull request can be released under the Apache 2 license

sonarcloud[bot] commented 3 weeks ago

Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint