Open ramakrishna-g1 opened 1 month ago
uploads are not stopped / aborted in case of any issues/exception when transferManager.close(); is used.
Closing the S3TransferManager won't interrupt transfers that are in flight, only future transfers.
Questions:
Describe the bug
We have triggered uploads for 2k files. Multiple files uploads triggered using S3TransferManager. transferManager.uploadFile(uploadFileRequest). Uploads are not cancelled/stopped when transferManager.close(); used in case of any exception while uploads in progress.
Regression Issue
Expected Behavior
Should be able to abort ongoing S3 uploads even after closing transfer manager using transferManager.close();
Current Behavior
S3 Uploads are continuing after transferManager.close();
Reproduction Steps
Below code snippet is used for creating S3TransferManager & S3AsyncClient. ----- create S3AsyncClient ------ public S3AsyncClient getS3AsyncClient(ThreadPoolExecutor threadPoolExecutor) {
----- create transfer manager ------ public S3TransferManager createTransferManager(S3AsyncClient s3AsyncClient, ThreadPoolExecutor threadPoolExecutor) { return S3TransferManager.builder() .s3Client(s3AsyncClient) .executor(threadPoolExecutor) .build(); } ----- Upload logic ------ List fileUploadList=new ArrayList(0);
Abort logic - uploads are not stopped / aborted in case of any issues/exception when transferManager.close(); is used.
Possible Solution
SDK should have mechanism to abort ongoing uploads.
Additional Information/Context
No response
AWS Java SDK version used
2.25.65
JDK version used
17
Operating System and version
Ubuntu 20.04.6 LTS