Use biome CLI for formatting client types map

trivikr commented 3 months ago

Issue

Missed while migrating to biome in https://github.com/aws/aws-sdk-js-codemod/pull/886

Description

Removes prettier API call while generating client types map

Testing

Generated client types map by running

$ yarn tsx scripts/generateClientTypesMap/index.ts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: d10644e50e78dcb8f6948d4ae77e0bd526753c44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

trivikr commented 3 months ago

Generating client types maps throws following error while formatting

/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/dist/wasm.js:84
        return new WasmError(e);
               ^

WasmError
    at Function.fromError (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/src/wasm.ts:75:10)
    at wrapError (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/src/wasm.ts:85:19)
    at Biome.tryCatchWrapper (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/src/index.ts:149:19)
    at Biome.withFile (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/src/index.ts:158:15)
    at Biome.formatContent (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/src/index.ts:195:15)
    at <anonymous> (/Users/trivikram/workspace/aws-sdk-js-codemod/scripts/generateClientTypesMap/index.ts:41:29) {
  stackTrace: Error: Size of /Users/trivikram/workspace/aws-sdk-js-codemod/src/transforms/v2-to-v3/config/CLIENT_TYPES_MAP.ts is 1.0 MiB which exceeds configured maximum of 1.0 MiB for this project.
  The file size limit exists to prevent us inadvertently slowing down and loading large files that we shouldn't.
  Use the `files.maxSize` configuration to change the maximum size of files processed.
      at module.exports.__wbg_new_28c511d9baebfa89 (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/wasm-nodejs/biome_wasm.js:922:17)
      at wasm://wasm/02c92192:wasm-function[10295]:0x8f26e6
      at wasm://wasm/02c92192:wasm-function[699]:0x38b188
      at wasm://wasm/02c92192:wasm-function[6635]:0x837029
      at Workspace.pullDiagnostics (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/wasm-nodejs/biome_wasm.js:549:18)
      at <anonymous> (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/src/index.ts:198:43)
      at <anonymous> (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/src/index.ts:170:12)
      at Biome.tryCatchWrapper (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/src/index.ts:147:11)
      at Biome.withFile (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/src/index.ts:158:15)
      at Biome.formatContent (/Users/trivikram/workspace/aws-sdk-js-codemod/node_modules/@biomejs/js-api/src/index.ts:195:15)
}

Node.js v20.16.0

There doesn't seem to be an option to programmatically set files.maxSize in @biomejs/js-api types.

github-actions[bot] commented 3 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

aws / aws-sdk-js-codemod