aws / aws-sdk-js-codemod

Codemod scripts to update AWS SDK for JavaScript APIs.
MIT No Attribution
73 stars 10 forks source link

Move testChangedPackageNames prior to changeset publish #967

Closed trivikr closed 1 week ago

trivikr commented 1 week ago

Issue

The testChangedPackageNames script was not run on publish

No changesets found. Attempting to publish any unpublished packages to npm
No user .npmrc file found, creating one
/usr/local/bin/npm run release

> aws-sdk-js-codemod@2.4.3 release
> npm run build && changeset publish

https://github.com/aws/aws-sdk-js-codemod/actions/runs/11678054032/job/32516955805

This happens as changesets does not run pre and post publish scripts https://github.com/changesets/changesets/issues/982

Description

Move testChangedPackageNames prior to changeset publish

Testing

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: cdab854902df2151251be623b8261b82f81de831

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

trivikr commented 1 week ago

The script was run in v2.4.4 release

> aws-sdk-js-codemod@2.4.4 release
> tsx scripts/testUpdatedIdentifiers && npm run build && changeset publish

Changed package names: [  ]
Changed clients: [  ]

> aws-sdk-js-codemod@2.4.4 build
> tsc

https://github.com/aws/aws-sdk-js-codemod/actions/runs/11716737001/job/32635295989