search

aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
3.04k stars 570 forks source link

build folders inside codegen are not ignored #1380

Closed trivikr closed 4 years ago

trivikr commented 4 years ago

Describe the bug build folders inside codegen are not ignored. Sometimes they can get mistakenly added in PRs like https://github.com/aws/aws-sdk-js-v3/pull/1375

SDK version number master

To Reproduce (observed behavior) On running yarn generate-clients, the codegen/smithy-aws-typescript-codegen/build folder is added as untracked:

$ yarn generate-clients -g codegen/sdk-codegen/aws-models/dynamodb.2012-08-10.json

...

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        codegen/smithy-aws-typescript-codegen/build/

nothing added to commit but untracked files present (use "git add" to track)

One running ./gradlew build in codegen folder, several build folders are added as untracked:

$ cd codegen

$ /gradlew build

...

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        protocol-test-codegen/build/
        sdk-codegen/build/
        smithy-aws-typescript-codegen/build/

nothing added to commit but untracked files present (use "git add" to track)

Expected behavior The build folders from codegen shouldn't be added as untracked, and should be ignored by git.

github-actions[bot] commented 3 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.