aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
3.12k stars 578 forks source link

Support AWS SigV2 #4032

Closed Edgar-P-yan closed 6 months ago

Edgar-P-yan commented 2 years ago

Describe the feature

Hi! aws-sdk v2 had an option signatureVersion: 'v2' | 'v4' which allowed to switch to the old and deprecated AWS SigV2.

Use Case

While it is recomended to use the newest V4, some third-party S3 storages still require the old version. So supporting it would be really helpful.

Proposed Solution

The feature can be introduced as a new package @aws-sdk/signature-v2 (similar to the current @aws-sdk/signature-v4 package) which will export a class SignatureV2 implements RequestPresigner, RequestSigner, StringSigner, EventSigner

Other Information

No response

Acknowledgements

SDK version used

^3.186.0

Environment details (OS name and version, etc.)

Ubuntu WSL

shirady commented 1 year ago

I'm also requesting this feature.

In the AWS SDK V2, signatureVersion is a property in the s3-client constructor. But, unfortunately, it was removed from AWS SDK V3 (copied from the Upgrading Notes):

v2: The signature version to sign requests with (overriding the API configuration). v3: Deprecated. Signature V2 supported in v2 SDK has been deprecated by AWS. v3 only supports signature v4.

Since the endpoint can be an s3-storage server that might be using only signature Version v2, please consider this decision again :pray:.

aBurmeseDev commented 6 months ago

Hey all - sorry for the long wait.

We had a team discussion about this today and unfortunately, we won't be implementing this since the ask here to make it work for "some third-party S3 storages still require the old version" and our SDK is only to be compatible with AWS (services). Let us know if you have any other questions.

github-actions[bot] commented 5 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.