aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
3.12k stars 579 forks source link

The runtime-dep-version-check is failing when bumping smithy deps #5136

Closed trivikr closed 1 year ago

trivikr commented 1 year ago

Checkboxes for prior research

Describe the bug

The following error is thrown by precommit when trying to bump dependencies in https://github.com/aws/aws-sdk-js-v3/pull/5130

husky > pre-commit (node v18.17.1)
ℹ No staged files match any configured task.
$ node scripts/runtime-dependency-version-check/runtime-dep-version-check.js
There is more than one version of a declared runtime dependency.
@smithy/config-resolver {
  '^2.0.5': '362 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/hash-node {
  '^2.0.5': '362 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/middleware-retry {
  '^2.0.5': '362 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
...

We added some temporary hacks to unblock, as the release was blocked. But this issue needs to be fixed.****

SDK version number

main

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

N/A

Reproduction Steps

Tested with commit d942a87 of smithy-typescript.

# State prior to PR https://github.com/aws/aws-sdk-js-v3/pull/5130
$ git checkout -b temp d6d6fd2da754e20aa866854edc7ff028d2c0d356

# Cherry-pick codegen changes from https://github.com/aws/aws-sdk-js-v3/pull/5131
$ git cherry-pick b3f447d51a09d25b5ac19f95beb8c9e164f935f5

# generate clients
$ yarn generate-clients

$ git add .

$ git commit -m "chore(clients): bump @smithy/* dependencies"

Observed Behavior

The following error is thrown:

$ node scripts/runtime-dependency-version-check/runtime-dep-version-check.js
There is more than one version of a declared runtime dependency.
@smithy/config-resolver {
  '^2.0.5': '362 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/hash-node {
  '^2.0.5': '362 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/middleware-retry {
  '^2.0.5': '362 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/node-config-provider {
  '^2.0.5': '360 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/node-http-handler {
  '^2.0.5': '362 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/protocol-http {
  '^2.0.5': '362 locations',
  '^2.0.3': [
    '@aws-sdk/aws-client-retry-test',
    '@aws-sdk/aws-middleware-test',
    '@aws-sdk/aws-util-test'
  ]
}
There is more than one version of a declared runtime dependency.
@smithy/smithy-client {
  '^2.0.5': '362 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/types {
  '^2.2.2': '362 locations',
  '^2.2.0': [
    '@aws-sdk/aws-client-api-test',
    '@aws-sdk/aws-client-retry-test',
    '@aws-sdk/aws-middleware-test',
    '@aws-sdk/aws-util-test'
  ]
}
There is more than one version of a declared runtime dependency.
@smithy/url-parser {
  '^2.0.5': '362 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/util-body-length-node {
  '^2.1.0': '362 locations',
  '^2.0.0': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/util-defaults-mode-node {
  '^2.0.5': '362 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/util-stream {
  '^2.0.5': '33 locations',
  '^2.0.3': [ '@aws-sdk/aws-client-api-test', '@aws-sdk/aws-middleware-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/eventstream-serde-node {
  '^2.0.5': [
    '@aws-sdk/client-kinesis',
    '@aws-sdk/client-lambda',
    '@aws-sdk/client-lex-runtime-v2',
    '@aws-sdk/client-rekognitionstreaming',
    '@aws-sdk/client-s3',
    '@aws-sdk/client-transcribe-streaming'
  ],
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
There is more than one version of a declared runtime dependency.
@smithy/hash-stream-node {
  '^2.0.5': [
    '@aws-sdk/client-s3',
    '@aws-sdk/client-s3-control',
    '@aws-sdk/aws-protocoltests-restjson'
  ],
  '^2.0.3': [ '@aws-sdk/aws-client-api-test' ]
}
/local/home/trivikr/workspace/aws-sdk-js-v3/scripts/runtime-dependency-version-check/runtime-dep-version-check.js:108
    throw new Error(violations + " have inconsistent declared versions.");
    ^

Error: @smithy/config-resolver, @smithy/hash-node, @smithy/middleware-retry, @smithy/node-config-provider, @smithy/node-http-handler, @smithy/protocol-http, @smithy/smithy-client, @smithy/types, @smithy/url-parser, @smithy/util-body-length-node, @smithy/util-defaults-mode-node, @smithy/util-stream, @smithy/eventstream-serde-node, @smithy/hash-stream-node have inconsistent declared versions.
    at checkVersions (/local/home/trivikr/workspace/aws-sdk-js-v3/scripts/runtime-dependency-version-check/runtime-dep-version-check.js:108:11)
    at Object.<anonymous> (/local/home/trivikr/workspace/aws-sdk-js-v3/scripts/runtime-dependency-version-check/runtime-dep-version-check.js:50:1)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47

Expected Behavior

No error thrown when bumping @smithy/* dependencies in aws-sdk-js-v3 clients.

Possible Solution

No response

Additional Information/Context

No response

github-actions[bot] commented 1 year ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.