chore(codegen): adopt checked dependency imports for TypeScriptWriter

aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.

Apache License 2.0

3.06k stars 573 forks source link

chore(codegen): adopt checked dependency imports for TypeScriptWriter #6000

Closed kuhe closed 5 months ago

kuhe commented 5 months ago

Issue

https://github.com/smithy-lang/smithy-typescript/pull/1239

Description

This takes on the Smithy TS PR linked above. Now TypeScriptWriter::addImport is checked and will throw when called for a dependency that hasn't been registered.

This prevents a class of repeated developer errors where a dependency is being used but is not registered in package.json.

[x] CI passing
[x] run e2e

trivikr commented 5 months ago

The CheckStyle error for line length needs fix

Error: eckstyle] [ERROR] /home/runner/work/aws-sdk-js-v3/aws-sdk-js-v3/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddDocumentClientPlugin.java:130: Line is longer than 120 characters (found 133). [LineLength]

github-actions[bot] commented 5 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.