aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
2.97k stars 556 forks source link

test(protocoltests): string list header bindings that require quoting #6012

Open trivikr opened 2 months ago

trivikr commented 2 months ago

Issue

Fixed in https://github.com/smithy-lang/smithy/pull/1049

Description

Enables protocol tests for string list header bindings that require quoting

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

trivikr commented 2 months ago

Error

  ● RestJsonInputAndOutputWithQuotedStringHeaders:Request

    expect(received).toBe(expected) // Object.is equality

    Expected: "\"b,c\", \"\\\"def\\\"\", a"
    Received: "b,c, \"def\", a"

      3521 |
      3522 |     expect(r.headers["x-stringlist"]).toBeDefined();
    > 3523 |     expect(r.headers["x-stringlist"]).toBe('"b,c", "\\"def\\"", a');
           |                                       ^
      3524 |
      3525 |     expect(r.body).toBeFalsy();
      3526 |   }

      at Object.<anonymous> (test/functional/restjson1.spec.ts:3523:39)

  ● RestJsonInputAndOutputWithQuotedStringHeaders:Response

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      3915 |   Object.keys(paramsToValidate).forEach((param) => {
      3916 |     expect(r[param]).toBeDefined();
    > 3917 |     expect(equivalentContents(r[param], paramsToValidate[param])).toBe(true);
           |                                                                   ^
      3918 |   });
      3919 | });
      3920 |

      at test/functional/restjson1.spec.ts:3917:67
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/functional/restjson1.spec.ts:3915:33)