Closed trivikr closed 2 months ago
Internal JS-5174
We announced the end of support for Node.js 14.x in the AWS SDK for JavaScript (v3) starting May 1, 2024 back in October, 2023.
Bump engines to node >=16.0.0 in package.json
Verified that error would be thrown in Node.js 14.x if engine-strict=true is set.
engine-strict=true
$ client-acm> yarn build:include:deps ... $ client-acm> npm pack ... npm notice === Tarball Details === npm notice name: @aws-sdk/client-acm npm notice version: 3.564.0 npm notice filename: aws-sdk-client-acm-3.564.0.tgz npm notice package size: 55.5 kB npm notice unpacked size: 361.3 kB npm notice shasum: 15adf9677ea52d53c7a007914b7a4e5ce729c674 npm notice integrity: sha512-xLmbAmZTAPdeL[...]3DJdTfJPJN53A== npm notice total files: 89 npm notice aws-sdk-client-acm-3.564.0.tgz
$ test> node -v v14.21.3 $ test> npm config set engine-strict false $ test> npm install ../aws-sdk-js-v3/clients/client-acm/aws-sdk-client-acm-3.564.0.tgz ... + @aws-sdk/client-acm@3.564.0 $ test> npm config set engine-strict true $ test> npm install ../aws-sdk-js-v3/clients/client-acm/aws-sdk-client-acm-3.564.0.tgz ... npm ERR! code ENOTSUP npm ERR! notsup Unsupported engine for @aws-sdk/client-acm@3.564.0: wanted: {"node":">=16.0.0"} (current: {"node":"14.21.3","npm":"6.14.18"}) npm ERR! notsup Not compatible with your version of node/npm: @aws-sdk/client-acm@3.564.0 npm ERR! notsup Not compatible with your version of node/npm: @aws-sdk/client-acm@3.564.0 npm ERR! notsup Required: {"node":">=16.0.0"} npm ERR! notsup Actual: {"npm":"6.14.18","node":"14.21.3"} ...
Error is not thrown on Node.js 16.x
$ test> node -v v16.20.2 $ test> npm config set engine-strict true $ test> npm install ../aws-sdk-js-v3/clients/client-acm/aws-sdk-client-acm-3.564.0.tgz ... $ test> npm why @aws-sdk/client-acm @aws-sdk/client-acm@3.564.0 node_modules/@aws-sdk/client-acm @aws-sdk/client-acm@"file:../aws-sdk-js-v3/clients/client-acm/aws-sdk-client-acm-3.564.0.tgz" from the root project
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.
Issue
Internal JS-5174
We announced the end of support for Node.js 14.x in the AWS SDK for JavaScript (v3) starting May 1, 2024 back in October, 2023.
Description
Bump engines to node >=16.0.0 in package.json
Testing
Verified that error would be thrown in Node.js 14.x if
engine-strict=true
is set.Error is not thrown on Node.js 16.x
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.