aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
2.97k stars 556 forks source link

feat(core): add AccountIdEndpointMode config option #6036

Open siddsriv opened 2 months ago

siddsriv commented 2 months ago

Issue

Internal JS-4633 Part 3

Description

Adds support for AccountIdEndpointMode config option. (client config, env, config file)

Testing

(this is before the merging of https://github.com/aws/aws-sdk-js-v3/pull/6035 which is why accountId is generated as well)

Checklist


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

siddsriv commented 2 weeks ago

possibly requires a careful look: exporting from account-id-endpoints submodule especially for config options since they will be used during runtime. the exports for this dir in package.json look right to me, let me know if i missed anything -- all tests are working okay, though it's a little tough to fully test the new client config option's functioning during runtime. i manually confirmed that everything is being imported correctly and the loading statements are correct in the generated client.