aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
3.06k stars 573 forks source link

chore(clients): extend TypeScript config from @tsconfig/node16 #6037

Closed trivikr closed 5 months ago

trivikr commented 5 months ago

Issue

Internal JS-5174

End of support for Node.js 14.x https://github.com/aws/aws-sdk-js-v3/pull/6034

Description

Extend TypeScript config from @tsconfig/node16

Testing

Verified using aws-samples/aws-sdk-js-tests

# in aws-sdk-js-v3
$ client-cognito-identity> npm pack
...
aws-sdk-client-cognito-identity-3.565.0.tgz

$ client-dynamodb> npm pack
...
aws-sdk-client-dynamodb-3.565.0.tgz

$ credential-provider-cognito-identity> npm pack
...
aws-sdk-credential-provider-cognito-identity-3.565.0.tgz
# in aws-sdk-js-tests
$ utils> yarn add ~/workspace/aws-sdk-js-v3/clients/client-cognito-identity/aws-sdk-client-cognito-identity-3.565.0.tgz

$ utils> yarn add ~/workspace/aws-sdk-js-v3/clients/client-dynamodb/aws-sdk-client-dynamodb-3.565.0.tgz

$ utils> yarn add ~/workspace/aws-sdk-js-v3/packages/credential-provider-cognito-identity/aws-sdk-credential-provider-cognito-identity-3.565.0.tgz

# Update packages/utils/src/config.js
$ aws-sdk-js-tests> yarn start:node
# successful listTables call from DynamoDB printed on console

$ aws-sdk-js-tests> yarn start:web
# successful listTables call from DynamoDB shown in browser

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions[bot] commented 4 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.