aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
2.96k stars 556 forks source link

chore(core): skip emitting warning for Node.js 14.x #6044

Closed trivikr closed 2 months ago

trivikr commented 2 months ago

Issue

Internal JS-5174

Support for Node.js 14.x ended in https://github.com/aws/aws-sdk-js-v3/pull/6034

Description

Skip emitting warning for Node.js 14.x

Testing

Build client-dynamodb in aws-sdk-js-v3

$ client-dynamodb> yarn build:include:deps

Prepare test file in test package

$> echo 'import { DynamoDB } from "../aws-sdk-js-v3/clients/client-dynamodb/dist-cjs/index.js"; const client = new DynamoDB();' > index.mjs

Before

$> node -v
v14.21.3

$> node index.mjs
(node:38205) Warning: NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
no longer support Node.js 14.x on May 1, 2024.

To continue receiving updates to AWS services, bug fixes, and security
updates please upgrade to an active Node.js LTS version.

More information can be found at: https://a.co/dzr2AJd
(Use `node --trace-warnings ...` to show where the warning was created)

After

No warning is emitted. No error is thrown during client creation, as we don't use Node.js 16.x specific API or specification.

$> node -v
v14.21.3

$> node index.mjs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions[bot] commented 1 month ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.