aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
2.96k stars 556 forks source link

test(middleware-sdk-s3): add waiter for objects in s3 express e2e test #6061

Closed siddsriv closed 2 months ago

siddsriv commented 2 months ago

Issue

Internal JS-5161

Description

adds a waiter for objects to exist

Testing

 PASS  packages/middleware-sdk-s3/src/s3-express/middleware-s3-express.e2e.spec.ts (6.363 s)
  s3 express CRUD test suite
    ✓ can create a bucket (2 ms)
    ✓ can read/write/delete from a bucket (1 ms)
    ✓ can presign get (74 ms)
    ○ skipped can presign put

Test Suites: 1 passed, 1 total
Tests:       1 skipped, 3 passed, 4 total
Snapshots:   0 total
Time:        6.416 s
Ran all test suites matching /middleware-s3-express.e2e.spec.ts/i.

Additional context

Add any other context about the PR here.

Checklist


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

siddsriv commented 2 months ago

closing this PR since Amazon S3 has strong consistency for objects. A waiter is probably not needed for objects here.

github-actions[bot] commented 1 month ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.